Closed
Conversation
Contributor
Author
|
Closing in favor of #598 |
|
Can this be reconsidered please? The other one is a very hard breaking change to all projects using coverage.py for instance (I bet there are other uses as well). Now the disaster has already happened, so it might be 'too late' or something, but I believe that this PR would have otherwise been a net benefit rather than what happened there. Example of how projects needed to adapt: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #598 targeting just the
.gitdirectory.We want to ensure this action is safe by default and users can't accidentally upload their Git credentials into an artifact that can then be exfiltrated.
This is still a breaking change, but less impactful than #598.
Users can opt out of this change by setting the newly added
include-git-directoryinput.