Skip to content

Conversation

@ncalteen
Copy link
Collaborator

This PR converts the TypeScript action template to ESM. Given that some of the core dependencies used in GitHub Actions (namely octokit/rest.js) are being converted to modules, it is necessary to make this change in new actions going forward.

The core changes are as follows:

  • Switch from @vercel/ncc to rollup for packaging the transpiled action code
  • Create separate TSConfig files for ESLint and Rollup
  • Configure Jest to handle ESM module loading and proper mocking of dependencies
  • Upgraded ESLint to 9.x (requires update from YAML to flat config format

Some additional changes that are included for convenience/ease of use:

  • Added links/references to specific linting configuration files
  • Added information on updating the CODEOWNERS file
  • Added test fixtures to stub @actions/core during unit tests
  • Added information on enforcing unit test coverage (optional)

@ncalteen ncalteen self-assigned this Nov 15, 2024
@ncalteen ncalteen requested a review from a team as a code owner November 15, 2024 16:54
Copy link
Contributor

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fniephaus added a commit to graalvm/setup-graalvm that referenced this pull request Sep 16, 2025
fniephaus added a commit to graalvm/setup-graalvm that referenced this pull request Sep 16, 2025
fniephaus added a commit to graalvm/setup-graalvm that referenced this pull request Sep 16, 2025
fniephaus added a commit to graalvm/setup-graalvm that referenced this pull request Sep 16, 2025
fniephaus added a commit to graalvm/setup-graalvm that referenced this pull request Sep 23, 2025
fniephaus added a commit to graalvm/setup-graalvm that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants