Cache: Increasing client validation to 10GB #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 12, 2021 11:21
|
Please update the README as well: toolkit/packages/cache/README.md Line 7 in e2eeb0a |
|
LGTM to me, but holding back on the sign off to make sure that README is updated. |
|
Hey @dhadka , The npm audit check has been failing. Is it okay to tackle it separately and not include it in this PR? |
|
@aparna-ravindra re: "The npm audit check has been failing. Is it okay to tackle it separately and not include it in this PR?", I would check with the actions-service team to see if they plan to do this as that audit is running against the entire toolkit and not just this module. But I do agree it makes sense to tackle it separately. |
aparna-ravindra
deleted the
users/aparna-ravindra/cache-client-check-data-limit
branch
This was referenced Nov 19, 2021
Chocobo1
added a commit
to Chocobo1/setup-ccache-action
that referenced
this pull request
Nov 23, 2021
Now it defaults to ccache default 5G. This is to provide better cache behavior with upstream change: actions/toolkit#934
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toolkit contains a check on the client side to ensure that the cache artifact being uploaded is atmost 5GB in size. This PR aims at increasing the size limit to 10GB instead.
The ADR for this change can be found here.