Skip to content

Exec: throw error when cwd option does not exist#793

Merged
luketomlinson merged 2 commits intomainfrom
bugfix/573-bad-exec-error
May 7, 2021
Merged

Exec: throw error when cwd option does not exist#793
luketomlinson merged 2 commits intomainfrom
bugfix/573-bad-exec-error

Conversation

@luketomlinson
Copy link
Copy Markdown
Contributor

Resolves #573

This will throw an error when the provided options.cwd does not exist. I believe this will also handle #737 as we are adding a try/catch at the top level which should handle any previously uncaught errors.

There is some linting, so I recommend turn whitespace diffs off for review.

@luketomlinson luketomlinson requested a review from a team as a code owner May 6, 2021 17:06
@luketomlinson luketomlinson force-pushed the bugfix/573-bad-exec-error branch from 38c9acd to 3ab3a33 Compare May 7, 2021 12:25
@luketomlinson luketomlinson force-pushed the bugfix/573-bad-exec-error branch from 3ab3a33 to c0f1ad9 Compare May 7, 2021 12:27
Copy link
Copy Markdown
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luketomlinson luketomlinson merged commit 09e59b9 into main May 7, 2021
@luketomlinson luketomlinson deleted the bugfix/573-bad-exec-error branch May 7, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passing an invalid path into @actions.exec.exec options argument throws confusing errror

2 participants