Skip to content

Get linux version from os-release file if available - #594

Merged
thboop merged 1 commit into
actions:mainfrom
ukstv:main
May 28, 2021
Merged

thboop merged 1 commit into
actions:mainfrom
ukstv:main

Conversation

@ukstv

@ukstv ukstv commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

Not all Linux distributions have /etc/lsb-release file available. If you try to use local runner like https://github.com/nektos/act it fails to perform actions relying on the toolkit. Say setup-python action can not proceed because of /etc/lsb-release missing. It can not determine version of python distribution to setup for a void os version.

There is one more, apparently more widely used, file /etc/os-release that contains release version information similar to lsb-release. This pull request adds support for getting os version from /etc/os-release file.

@ukstv

ukstv commented Nov 18, 2020

Copy link
Copy Markdown
Contributor Author

So when release?

@thboop thboop left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thboop

thboop commented May 28, 2021

Copy link
Copy Markdown
Collaborator

Thanks for the contribution @ukstv we will get this released early next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants