Skip to content

Use import {Octokit}#332

Merged
thboop merged 2 commits intoactions:masterfrom
nwtgck:patch-1
Feb 18, 2020
Merged

Use import {Octokit}#332
thboop merged 2 commits intoactions:masterfrom
nwtgck:patch-1

Conversation

@nwtgck
Copy link
Copy Markdown
Contributor

@nwtgck nwtgck commented Feb 4, 2020

Hi,

The purpose of this PR is to remove the following error.

node_modules/@actions/github/lib/github.d.ts:2:8 - error TS2613: Module '"/.../node_modules/@octokit/rest/index"' has no default export. Did you mean to use 'import { Octokit } from "/.../node_modules/@octokit/rest/index"' instead?

2 import Octokit from '@octokit/rest';
         ~~~~~~~

@xt0rted
Copy link
Copy Markdown
Contributor

xt0rted commented Feb 5, 2020

This change was made i n v16.43.1 but the version in package.json is v16.15.0 which is why all the builds failed.

@nwtgck
Copy link
Copy Markdown
Contributor Author

nwtgck commented Feb 5, 2020

@xt0rted Thanks! Umm... Interesting...

Actually, my project using @actions/github fails in build-time when import Octokit from '@octokit/rest'; is used. To avoid this, I manually modify .d.ts in node_modules: nwtgck/actions-netlify#2.

@nwtgck
Copy link
Copy Markdown
Contributor Author

nwtgck commented Feb 5, 2020 •
edited
Loading

I found the reason.

16.43.1 (2020-02-03)
Bug Fixes
TypeScript: named { Octokit } export (486eadd)

https://github.com/octokit/rest.js/releases/tag/v16.43.1

@nwtgck nwtgck mentioned this pull request Feb 5, 2020
Closed
@technote-space
Copy link
Copy Markdown

technote-space commented Feb 5, 2020 •
edited
Loading

^16.15.0 = 16.x
so v16.43.1 is installed.
I think this PR needs to be merged as soon as possible.

If you want to build with tsc now, add skipLibCheck setting.

tsconfig.json

{
  "compilerOptions": {
    "skipLibCheck": true,

   ...

  }
}

@nwtgck
Copy link
Copy Markdown
Contributor Author

nwtgck commented Feb 5, 2020

@technote-space Thank you very much for your useful tip: skipLibCheck. I didn't know that.

@nwtgck nwtgck mentioned this pull request Feb 5, 2020
Closed
hardboiled
hardboiled approved these changes Feb 6, 2020
View reviewed changes
Copy link
Copy Markdown

@hardboiled hardboiled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will definitely fix the problem I mentioned in my comment. Thanks for opening!

piraka9011
piraka9011 approved these changes Feb 11, 2020
View reviewed changes
Copy link
Copy Markdown

@piraka9011 piraka9011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump! Can we get this in soon please!

@piraka9011 piraka9011 mentioned this pull request Feb 11, 2020
Merged
@technote-space technote-space mentioned this pull request Feb 12, 2020
Closed
@joshmgross
Copy link
Copy Markdown
Contributor

joshmgross commented Feb 18, 2020

This resolves #333

thboop
thboop approved these changes Feb 18, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@thboop thboop merged commit fa03eb4 into actions:master Feb 18, 2020
@nwtgck nwtgck deleted the patch-1 branch February 18, 2020 23:47
@gomorizsolt gomorizsolt mentioned this pull request Feb 19, 2020
Merged
@joshmgross joshmgross mentioned this pull request Feb 19, 2020
Closed
@thboop thboop mentioned this pull request Mar 2, 2020
Closed
@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Closed
@christian-korneck christian-korneck mentioned this pull request Apr 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thboop thboop thboop approved these changes

+4 more reviewers

@hardboiled hardboiled hardboiled approved these changes

@rdelgatte rdelgatte rdelgatte approved these changes

@piraka9011 piraka9011 piraka9011 approved these changes

@technote-space technote-space technote-space approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nwtgck @xt0rted @technote-space @joshmgross @hardboiled @rdelgatte @piraka9011 @thboop