Skip to content

Update octokit graphql type dependencies#228

Merged
hross merged 2 commits intoactions:masterfrom
hross:update_graphql
Dec 6, 2019
Merged

Update octokit graphql type dependencies#228
hross merged 2 commits intoactions:masterfrom
hross:update_graphql

Conversation

@hross
Copy link
Copy Markdown
Contributor

@hross hross commented Nov 22, 2019

This fix attempts to address the issue with custom type definitions here: #199

@hross
Copy link
Copy Markdown
Contributor Author

hross commented Nov 22, 2019

Looks like this will break the contract for graphQL a bit, but then again the octokit already broke that contract on update. I did the following to test the changes:

  • Create test action that runs a graphQL query using the old library
  • Move module reference to local version of this same code
  • Verify we can still call graphQL and get the same results using the token

TLDR: this might change the contract when we republish a new version, but I think that is OK.

@hross hross changed the title Update graphQL type dependencies Update octokit graphql type dependencies Nov 26, 2019
@hross hross marked this pull request as ready for review November 26, 2019 15:32
Copy link
Copy Markdown
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thboop
Copy link
Copy Markdown
Collaborator

thboop commented Dec 3, 2019

We will want to update Releases.MD before the release.

@hross hross merged commit 5fdab2a into actions:master Dec 6, 2019
Bullrich added a commit to Bullrich/Prace.js that referenced this pull request Jan 14, 2022
## System changed
- Dependency versions
- Build

## Description

Updated packages to latest version to support new features available in GitHub Actions, including GitHub enterprise edition (this PR brings that new functionality: actions/toolkit#794).

Some dependency types have changed and they have been updated to the new types.

The `octokitHack.ts` file is no longer needed as that bug has been fixed: actions/toolkit#228

The build directory has been recreated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants