Skip to content

fix unzip error#223

Merged
ericsciple merged 2 commits intoactions:masterfrom
UziTech:unzip
Dec 9, 2019
Merged

fix unzip error#223
ericsciple merged 2 commits intoactions:masterfrom
UziTech:unzip

Conversation

@UziTech
Copy link
Copy Markdown
Contributor

@UziTech UziTech commented Nov 16, 2019 •
edited
Loading

Fixes these errors when extracting a zip/tar/7z file to a destination folder that does not exist.

tar on macos and linux

/bin/tar: /home/runner/work/toolkit/toolkit/packages/tool-cache/__tests__/TEMP/test-
install-tar.gz/not-exist: Cannot open: No such file or directory

7z on windows

ENOENT: no such file or directory, chdir 'D:\a\toolkit\toolkit\packages\exec\__tests__'
-> 'D:\a\toolkit\toolkit\packages\tool-cache\__tests__\test-install-7z\not-exist'

zip on macos

There was an error when attempting to execute the process '/usr/bin/unzip'. This may
indicate the process failed to start. Error: spawn /usr/bin/unzip ENOENT

fixes #213
fixes #82

This was referenced Nov 16, 2019
Merged
Closed
@UziTech UziTech force-pushed the unzip branch 3 times, most recently from 85d43ba to eaa732c Compare November 21, 2019 05:53
@UziTech
Copy link
Copy Markdown
Contributor Author

UziTech commented Nov 21, 2019 •
edited
Loading

looks like an exec test is timing out in windows even when I remove my changes.

@hross
Copy link
Copy Markdown
Contributor

hross commented Dec 3, 2019

I fixed the test timeout issue in master if you want to try again

@UziTech
Copy link
Copy Markdown
Contributor Author

UziTech commented Dec 3, 2019

@hross seems to work now, thanks.

@UziTech
Copy link
Copy Markdown
Contributor Author

UziTech commented Dec 9, 2019

Any feedback on this?

hross
hross approved these changes Dec 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@hross hross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change. @ericsciple I think we should merge this.

@ericsciple ericsciple merged commit 1d7e38e into actions:master Dec 9, 2019
@ericsciple
Copy link
Copy Markdown
Contributor

ericsciple commented Dec 9, 2019

Thanks @UziTech , especially for the tests :)

@abhiabhi94 abhiabhi94 mentioned this pull request Dec 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsciple ericsciple ericsciple approved these changes

+1 more reviewer

@hross hross hross approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve error message when using extractZip/extract7z/extractTar with a non-existing destination tool-cache extractZip not working

3 participants

@UziTech @hross @ericsciple