tool-cache: Support for extracting xar compatible archives#207
tool-cache: Support for extracting xar compatible archives#207thboop merged 15 commits intoactions:masterfrom fwal:tool-cache-xar
Conversation
|
Seems that I made an assumption that Edit: As there are windows-only extractors already present, I think this should be fine. |
|
Adding Eric for his thoughts. Caution that there is a binary in this PR. |
|
I think it's fine to have OS specific variants since some tool installers expose archives in various formats per OS. Curious, was there a specific tool / installer that exposed the tool via a xar that your were interested in writing a setup action for? The reason I ask, is I'm up for taking the functionality as long as there's a benefit trading off the maintenance and cost going forward ... |
|
Sure! I use this in my setup swift action. The feature in question is used to unpack official swift pkg archives from swift.org. I opted to just copy the required function in there for now. |
thboop
left a comment
There was a problem hiding this comment.
Some minor feedback! Let me know if you don't have time to continue with the PR and I can take it over.
Thank you!
|
... although we'd ❤️ to take the contribution from you @fwal . Do you have time? No rush on our side. |
|
Thanks for the feedback! I’ll address everything during next week as it’s holiday here 🇸🇪 |
# Conflicts: # packages/tool-cache/__tests__/tool-cache.test.ts
This reverts commit a6cbddc.
|
Ready for you, @thboop & @bryanmacfarlane. |
|
Thanks for the contribution! Going to release this in |
Adds support for extracting archives compatible with eXtensible ARchiver, most notably
*.pkgarchives.