Merged
Conversation
bethanyj28
reviewed
Dec 6, 2023
Contributor
bethanyj28
left a comment
bethanyj28
left a comment
There was a problem hiding this comment.
A few suggestions, overall looks good!
Co-authored-by: Bethany <[email protected]>
Co-authored-by: Bethany <[email protected]>
Co-authored-by: Bethany <[email protected]>
Co-authored-by: Bethany <[email protected]>
Co-authored-by: Bethany <[email protected]>
mattiaerre
reviewed
Dec 6, 2023
| - [Additional Resources](#additional-resources) | ||
|
|
||
| This package is currently undergoing a major overhaul in preparation for `v4` versions of `upload-artifact` and `download-artifact` (these Actions will use a new `2.0.0` version of `@actions/artifact` that will soon be released). The upcoming version of `@actions/artifact` will take advantage of a major re-architecture with entirely new APIs. | ||
| ## v2 - What's New |
Contributor
There was a problem hiding this comment.
so v2 is to support Artifacts v4?
Contributor
Author
There was a problem hiding this comment.
Yea, the NPM package version of @actions/artifact is currently at v1.1.2. It drifts a bit from the actual actions versions, which get major bumps for other reasons (like node updates)
Contributor
There was a problem hiding this comment.
do you think we could follow the same versioning? can these be aligned? bad idea?
Contributor
Author
There was a problem hiding this comment.
I don't think so, it'll cause some confusion on the missing v3 and v4 versions.
And even if we did, the actions will probably deviate in the future too
konradpabjan
reviewed
Dec 6, 2023
konradpabjan
reviewed
Dec 6, 2023
Co-authored-by: Konrad Pabjan <[email protected]>
konradpabjan
reviewed
Dec 6, 2023
konradpabjan
approved these changes
Dec 6, 2023
Co-authored-by: Konrad Pabjan <[email protected]>
Co-authored-by: Konrad Pabjan <[email protected]>
mattiaerre
reviewed
Dec 6, 2023
Co-authored-by: Mattia Richetto <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This starts the initial documentation for
@action/artifactv2.I'll be following up in another PR with autogenerated markdown docs for the functions, interfaces, etc.
Also, this change alters the export behavior of the default client.
Instead of:
Now there is a default export with the client already initialized: