Skip to content

Migrate dev environment and workflows to node16 #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhammerl merged 16 commits into from
Jan 3, 2023
Merged

Migrate dev environment and workflows to node16 #1278

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
23811ac
Update nock to work with node 16
fhammerl Dec 13, 2022
c91bdba
Update ts types to node16
fhammerl Dec 14, 2022
cc9ec04
Test out checking for fileexists in rmFile
fhammerl Dec 14, 2022
e1a991f
Run workflows on 16
fhammerl Dec 14, 2022
56c4606
Fix audit
fhammerl Dec 14, 2022
6b18932
Fix missing typescript casts
fhammerl Dec 14, 2022
4abb5a2
Quote workflows for windows
fhammerl Dec 14, 2022
1d61e5f
Fix linting
fhammerl Dec 14, 2022
b9de68a
Await finish of filestream so file is created for node16
fhammerl Dec 14, 2022
80d9927
Fix linting
fhammerl Dec 14, 2022
2afea66
Try sequential jest tests
fhammerl Dec 20, 2022
894a049
Merge branch 'main' of https://github.com/actions/toolkit into fhamme…
fhammerl Jan 3, 2023
3d46598
Add disabling explanation in audit-allow-list
fhammerl Jan 3, 2023
af2d2ff
Remove allow-list from audit
fhammerl Jan 3, 2023
5e9bcac
Update title with hint
fhammerl Jan 3, 2023
4ea0831
Fix json5 vuln
fhammerl Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Await finish of filestream so file is created for node16
  • Loading branch information
@fhammerl
fhammerl committed Dec 14, 2022
commit b9de68a590daf37c6747e38d3cb4f1dd2cfb791c
12 changes: 10 additions & 2 deletions packages/artifact/src/internal/download-http-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,14 @@ export class DownloadHttpClient {
fileDownloadPath: string
): Promise<void> => {
destinationStream.close()
// await until file is created at downloadpath
// wrap destinationStream's open event in promise
await new Promise<void>(resolve => {
destinationStream.on('close', resolve)
if (destinationStream.writableFinished) {
resolve()
}
});
await rmFile(fileDownloadPath)
destinationStream = fs.createWriteStream(fileDownloadPath)
}
Expand Down Expand Up @@ -273,8 +281,8 @@ export class DownloadHttpClient {
// if a throttled status code is received, try to get the retryAfter header value, else differ to standard exponential backoff
isThrottledStatusCode(response.message.statusCode)
? await backOff(
tryGetRetryAfterValueTimeInMilliseconds(response.message.headers)
)
tryGetRetryAfterValueTimeInMilliseconds(response.message.headers)
)
: await backOff()
} else {
// Some unexpected response code, fail immediately and stop the download
Expand Down
9 changes: 0 additions & 9 deletions packages/artifact/src/internal/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,15 +270,6 @@ export async function getFileSize(filePath: string): Promise<number> {
}

export async function rmFile(filePath: string): Promise<void> {
// TODO: find actual fix
// node 16 `CreateWriteStream` no longer creates a file
// download-http-client.ts#L151 no longer creates a file and we fail here
try {
await fs.stat(filePath)
} catch (e) {
// File does not exist
return
}
await fs.unlink(filePath)
}

Expand Down