Skip to content

feat(options): add new option ignore-updates to stale even with activity#540

Merged
luketomlinson merged 27 commits intoactions:mainfrom
C0ZEN:feature/ignore-activity
Sep 17, 2021
Merged

feat(options): add new option ignore-updates to stale even with activity#540
luketomlinson merged 27 commits intoactions:mainfrom
C0ZEN:feature/ignore-activity

Conversation

@C0ZEN
Copy link
Copy Markdown
Contributor

@C0ZEN C0ZEN commented Jul 31, 2021

Changes

@C0ZEN
Copy link
Copy Markdown
Contributor Author

C0ZEN commented Sep 1, 2021

@luketomlinson any news?

@github-actions github-actions Bot removed the Stale label Sep 2, 2021
Copy link
Copy Markdown
Collaborator

@luketomlinson luketomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for the most part @C0ZEN. My only question is how we name the new options. And while I think these particular new options provide some value, I really want to start limiting the number of new options we add.

Comment thread __tests__/constants/default-processor-options.ts Outdated
@C0ZEN C0ZEN changed the title feat(options): add new option activities-reset-stale to stale even with activity feat(options): add new option ignore-updates to stale even with activity Sep 8, 2021
@peimanja
Copy link
Copy Markdown

Any update on this? 🙏

Copy link
Copy Markdown
Collaborator

@luketomlinson luketomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @C0ZEN 🥇

@C0ZEN C0ZEN force-pushed the feature/ignore-activity branch from 9eef113 to f05bb6f Compare September 14, 2021 21:30
@C0ZEN C0ZEN force-pushed the feature/ignore-activity branch from bc015ce to 5cd25d2 Compare September 14, 2021 21:53
@C0ZEN
Copy link
Copy Markdown
Contributor Author

C0ZEN commented Sep 15, 2021

@luketomlinson ready

@luketomlinson luketomlinson merged commit 1cdda06 into actions:main Sep 17, 2021
@C0ZEN C0ZEN deleted the feature/ignore-activity branch September 17, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to comprehend handling of stale issue when days-before-issue-stale is -1 Include option to ignore PR activity

3 participants