Skip to content

Conversation

@damccorm
Copy link
Contributor

@damccorm damccorm commented Jun 5, 2019

I think we can use husky to easily manage what needs to be checked in. It uses git hooks to require that this stuff is run before checkin. This way we also don't need to manually keep track of packages in .gitignore

@damccorm damccorm requested review from bryanmacfarlane and jclem June 5, 2019 19:24
@bryanmacfarlane
Copy link
Member

I like it

@bryanmacfarlane
Copy link
Member

Looks good to me. @jclem?

@jclem
Copy link

jclem commented Jun 7, 2019

I think we need to add a negative gitignore for node_modules—a lot of developers (myself included) will have node_modules in their global gitignore.

@damccorm
Copy link
Contributor Author

damccorm commented Jun 7, 2019

Makes sense, updated appropriately.

@damccorm damccorm merged commit 075e678 into master Jun 17, 2019
@damccorm damccorm deleted the husky branch June 17, 2019 13:32
maxim-lobanov pushed a commit that referenced this pull request Jun 30, 2021
* regenerate license

* npm run build

* sync branches

* rebuild project

* fix test

Co-authored-by: Dmitry Shibanov <[email protected]>
krzyk pushed a commit to krzyk/setup-node that referenced this pull request Apr 11, 2023
Adding defaults for edgerc credentials
deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023
* Add branch check

* Improve docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants