Add test for node-version *#491
Merged
dmitry-shibanov merged 2 commits intoactions:mainfrom May 18, 2022
Merged
Conversation
Contributor
|
Hello @jablko. Thank you for your pull request. I think only unit tests will be enough. |
Contributor
Author
|
dmitry-shibanov
approved these changes
May 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR only adds test coverage for existing behavior: It adds a unit and e2e test for node-version
*.What I did was:
it.each(table)--- but I'm happy to leave them unrolled if you prefer?setup-node/__tests__/installer.test.ts
Line 138 in 17f8bd9
setup-node/__tests__/installer.test.ts
Line 153 in 17f8bd9
setup-node/__tests__/installer.test.ts
Line 168 in 17f8bd9
*:*.Check list: