Skip to content

Conversation

@tyrann0us
Copy link
Contributor

@tyrann0us tyrann0us commented Apr 19, 2022

Description:
In writeRegistryToFile() (added in https://github.com/actions/setup-node/pull/21/files#diff-a3c83546a6fde2740e1dd05c8267c74af1c8a7fe3add285eea3669b3760ac6f3R25-R27), scope falls back to the repository owner if the npm.pkg.github.com registry (GitHub Packages) is used.
Since in most cases, this means that the scope parameter is not needed, but the logic is not documented anywhere, this PR adds the appropriate note to the parameter description.

Related issue:
None.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

This also ends all descriptions with a full stop (`.`).
@tyrann0us tyrann0us requested a review from a team April 19, 2022 13:47
tyrann0us added a commit to inpsyde/reusable-workflows that referenced this pull request Apr 19, 2022
Copy link
Contributor

@brcrista brcrista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@brcrista
Copy link
Contributor

@dmitry-shibanov FYI

@brcrista brcrista merged commit 86bf502 into actions:main Apr 19, 2022
deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.1 to 2.8.2.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.1...2.8.2)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants