-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: add support for current and latest aliases
#279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'd like to request that 'latest' also be supported, however even without it this would be great to have! Thank you for making the PR |
current aliascurrent and latest aliases
Done! 👍 |
|
Dowload ? |
|
From #278 (comment)
Could you review this PR and maybe include it in the next release if possible and everything is good to go, please ? 😄 @maxim-lobanov |
|
any chance to merge this? |
|
Hi, |
|
Thanks for your interest. @Kikobeats and @demurgos I'm happy to continue to work on this PR if it's needed. |
|
Hello @divlo. Thank you for your pull request. Could please attach link to the documentation for the |
Updated README and resolved the conflicts. 👍 |
|
Just a memory dump of prior art:
I'd argue |
|
Could it be that the two would exists ? "current" and "latest" being synonyms ? |
|
My thinking is that "latest" can be misleading, esp. in the context of there being "latest in a release line", "latest LTS", etc. I'd rather have I could be wrong in my thinking, of course. I'll try to dig out some more discussion threads about this for reference. |
|
I guess a lot of threads can be followed from nodejs/package-maintenance#236 I do have to admit, that I have an issue open on |
|
@dmitry-shibanov Friendly ping. 😄 What is needed to merge this PR? |
so does actions/setup-node support |
|
@bluelovers Does |
nvm , travis ci use |
|
This PR has no recent activity, and probably won't be merged for a long time and as I don't want/have time to do the job for this PR, I decided to close it. Feel free to open another PR yourself based on this one if you want this to be implemented. |
Bumps [@vercel/ncc](https://github.com/vercel/ncc) from 0.29.2 to 0.30.0. - [Release notes](https://github.com/vercel/ncc/releases) - [Commits](vercel/ncc@0.29.2...0.30.0) --- updated-dependencies: - dependency-name: "@vercel/ncc" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Fixes #257
The goal of this PR is to support
currentas alias for thenode-versionarray.I thought that
currentis a better name thanlatestbecause the actual name from Node.js iscurrentbut we can support both aliases if we really want to.Currently, this is a Work In Progress, I don't know much of this codebase, so I would appreciate some help.
I'm new to the world of developing GitHub Actions, I always use them but never develop them 😆, I saw that you can test if it actually works with the tool nektos/act.
So I ran this command :
act -j current-syntaxand it seems to work, but it is not caching the Node.js version yet.EDIT: I also added the
latestalias.