Repository navigation
fix: exclude prereleases when resolving latest/current/node aliases - #1668
Open
v-gowridurgad wants to merge 2 commits into
Open
v-gowridurgad wants to merge 2 commits into
v-gowridurgad wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The regression test can pass despite installation failure or an incorrect version because it checks only the initial cache lookup, not installation success or the stable download URL.
1 open issue
What changed in this PR
Updates Node.js alias resolution to address #1660: latest, current, and node skip prereleases and select the newest available stable release.
Changes:
- Filters prereleases during alias resolution and reports an explicit error when no stable release is available.
- Adds regression tests and updates the workflow’s expected version to exclude prereleases.
- Documents the behavior and updates the bundled action runtime.
| File | Description |
|---|---|
src/distributions/official_builds/official_builds.ts |
Selects stable releases for aliases and handles missing stable versions. |
README.md |
Documents stable-only alias resolution and failure behavior. |
dist/setup/index.js |
Includes the resolver changes in the runtime bundle. |
.github/workflows/versions.yml |
Excludes prereleases from the expected latest version. |
__tests__/official-installer.test.ts |
Adds mixed, empty, and prerelease-only index cases and strengthens cache assertions. |
Review effort: Balanced
2 of 5 tasks
v-priya-kinthali
approved these changes
Nov 13, 2026
v-priyagupta108
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
latest,currentandnodenow picks the newest entry without a prerelease tag, matching nodejs.orgwhere
/download/release/latest/points at the newest Current release.Related issue:
#1660
Check list: