Skip to content

feat: Add support for .sdkmanrc file in java-version-file parameter #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarithaVattikuti merged 13 commits into from
Nov 25, 2025
Merged

feat: Add support for .sdkmanrc file in java-version-file parameter #736

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b185b99
chore(e2e-versions): Add e2e test scenario on `setup-java-version-fro…
guicamest Jan 24, 2025
47407b3
chore(e2e-versions): Update `setup-java-version-from-file-major-minor…
guicamest Jan 24, 2025
556a113
feat: Add support for `.sdkmanrc` as *Java Version File*
guicamest Jan 25, 2025
3228b7f
chore: Add test for the latest known sdkman java versions
guicamest Jan 25, 2025
b38bd61
docs(advanced-usage): Document support for `.sdkmanrc` as java-versio…
guicamest Jan 25, 2025
dd4a6bd
chore(docs): Anyone can contribute and maintain :shrug:
guicamest Jan 25, 2025
54b5143
Update advanced-usage.md
guicamest Nov 13, 2025
507f216
Update advanced-usage.md
guicamest Nov 14, 2025
ebfc458
Update util.ts
guicamest Nov 14, 2025
d6f9a13
chore: format and rebuild
guicamest Nov 19, 2025
95f21d2
Merge branch 'actions:main' into feat/669/support_sdkmanrc
guicamest Nov 19, 2025
a985bcf
chore: untouch toolchains.ts
guicamest Nov 20, 2025
73b943d
fix check dist error
mahabaleshwars Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update util.ts
  • Loading branch information
@guicamest
guicamest authored Nov 14, 2025
commit ebfc458f30e8da6caeb5cd66ac311699cba1297b
10 changes: 5 additions & 5 deletions src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,16 +140,16 @@ export function getVersionFromFileContent(
javaVersionRegExp = /(?<version>(?<=(^|\s|-))(\d+\S*))(\s|$)/;
}

const fileContent = content.match(javaVersionRegExp)?.groups?.version
const capturedVersion = content.match(javaVersionRegExp)?.groups?.version
? (content.match(javaVersionRegExp)?.groups?.version as string)
: '';
if (!fileContent) {

core.debug(`Parsed version '${capturedVersion}' from file '${versionFileName}'`);
if (!capturedVersion) {
return null;
}

core.debug(`Version from file '${fileContent}'`);

const tentativeVersion = avoidOldNotation(fileContent);
const tentativeVersion = avoidOldNotation(capturedVersion);
const rawVersion = tentativeVersion.split('-')[0];

let version = semver.validRange(rawVersion)
Expand Down
Loading