Merged
Conversation
ericsciple
force-pushed
the
users/ericsciple/26-03-container
branch
from
f57da0c to
2136a36
Compare
ericsciple
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the runner’s workflow schema + conversion logic to treat empty container image strings as “no container” (null) at runtime, avoiding validation failures when expressions evaluate to empty. It also expands L0 coverage to ensure the legacy and new workflow parsers remain behaviorally consistent for these edge cases.
Changes:
- Relaxed
container-mapping.imageandservices-containerschema types fromnon-empty-stringtostring. - Updated
WorkflowTemplateConverter.ConvertToJobContainerto handle empty strings (includingdocker://prefix-only) by returningnull, while preserving parse-time validation for specific invalid cases. - Added L0 tests covering empty images and
docker://prefix-only scenarios for both job containers and service containers, ensuring both parsers agree.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Test/L0/Worker/PipelineTemplateEvaluatorWrapperL0.cs |
Adds parity tests for empty / docker://-only container images for job + services. |
src/Sdk/WorkflowParser/workflow-v1.0.json |
Relaxes schema to allow empty-string container image values. |
src/Sdk/WorkflowParser/Conversion/WorkflowTemplateConverter.cs |
Implements the new conversion behavior (empty image ⇒ null container) and trims docker:// consistently. |
TingluoHuang
reviewed
Mar 3, 2026
TingluoHuang
approved these changes
Mar 3, 2026
Port missing schema and converter changes from actions-workflow-parser PR #577. Relaxes container-mapping.image and services-container from non-empty-string to string so expressions that evaluate to empty at runtime return null (no container) instead of a validation error.
ericsciple
force-pushed
the
users/ericsciple/26-03-container
branch
from
2136a36 to
1e60897
Compare
dawidmalina
pushed a commit
to dawidmalina/github-runner
that referenced
this pull request
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes telemetry noise from parser comparison mismatches between legacy and new workflow parsers.
Fix: Port schema and converter changes from actions-workflow-parser PR 577. Relaxes container-mapping.image and services-container from non-empty-string to string so expressions that evaluate to empty at runtime return null (no container) instead of a validation error.