Skip to content

Log inner exception message.#4265

Merged
TingluoHuang merged 1 commit intomainfrom
users/tihuang/setuptelemtry
Feb 25, 2026
Merged

Log inner exception message.#4265
TingluoHuang merged 1 commit intomainfrom
users/tihuang/setuptelemtry

Conversation

@TingluoHuang
Copy link
Copy Markdown
Member

We always warp the original error:

throw new WebApi.FailedToResolveActionDownloadInfoException("Failed to resolve action download info.", ex);

So we want to log the inner exception message for better visibility.

@TingluoHuang TingluoHuang requested a review from a team as a code owner February 25, 2026 20:33
Copilot AI review requested due to automatic review settings February 25, 2026 20:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves error visibility by logging inner exception messages when handling FailedToResolveActionDownloadInfoException. Since this exception is always thrown as a wrapper around the original error (line 732: throw new WebApi.FailedToResolveActionDownloadInfoException("Failed to resolve action download info.", ex);), displaying the inner exception message provides more actionable information to users than the generic wrapper message.

Changes:

  • Modified exception handler to display inner exception message instead of wrapper message for better error diagnostics
  • Cleaned up trailing whitespace in action archive caching code

@TingluoHuang TingluoHuang merged commit 7650fc4 into main Feb 25, 2026
16 checks passed
@TingluoHuang TingluoHuang deleted the users/tihuang/setuptelemtry branch February 25, 2026 20:44
dawidmalina pushed a commit to dawidmalina/github-runner that referenced this pull request Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants