safe_sleep: now it's safe and it does sleep (with fallback to the busy-wait)#4139
Closed
kosa12 wants to merge 1 commit intoactions:mainfrom
Closed
safe_sleep: now it's safe and it does sleep (with fallback to the busy-wait)#4139kosa12 wants to merge 1 commit intoactions:mainfrom
kosa12 wants to merge 1 commit intoactions:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the safe_sleep.sh script by making it actually use the sleep command when available, with a fallback to the previous busy-wait implementation. This makes the script more efficient and resource-friendly by using proper sleep instead of spinning in a loop.
Key Changes
- Adds detection for the
sleepcommand availability usingcommand -v - Uses native
sleepwhen available for proper waiting behavior - Falls back to the original busy-wait loop when
sleepis unavailable
|
Duplicate of PR #3143 (from February 2024 😅) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.