Retry http error related to DNS resolution failure.#4110
Merged
TingluoHuang merged 1 commit intomainfrom Nov 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds retry logic for DNS resolution failures at the socket level by including SocketError.HostNotFound as a retryable network error, addressing issue #5782. The change ensures consistency across different exception types when handling transient DNS-related failures.
- Adds
SocketError.HostNotFoundto the list of retryable socket errors in network exception handling - Standardizes using statement ordering in VssHttpRetryMessageHandler.cs to follow C# conventions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Sdk/Common/Common/VssNetworkHelper.cs | Adds SocketError.HostNotFound to retryable network errors, ensuring DNS lookup failures at the socket level are retried consistently with other exception types |
| src/Sdk/Common/Common/VssHttpRetryMessageHandler.cs | Reorders using statements to follow standard C# convention (System namespaces first, alphabetically) |
luketomlinson
approved these changes
Nov 13, 2025
alinetskyi
pushed a commit
to CoreumFoundation/runner
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/github/c2c-actions-support/issues/5782