Custom Image: Preflight checks#4081
Merged
TingluoHuang merged 8 commits intoactions:mainfrom Oct 16, 2025
Merged
Conversation
lawrencegripper
commented
Oct 16, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements preflight checks for snapshot operations in GitHub Actions runners. The changes ensure that snapshots can only be created on appropriate environments by validating the runner type and image generation capabilities before proceeding with snapshot creation.
Key changes:
- Added preflight validation to check runner environment and image generation status
- Enhanced snapshot operation logging to include image name and version information
- Added comprehensive test coverage for various preflight check scenarios
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/Runner.Common/Constants.cs |
Added feature flags for snapshot preflight checks |
src/Runner.Worker/SnapshotOperationProvider.cs |
Implemented preflight check logic and enhanced logging |
src/Runner.Worker/JobExtension.cs |
Integrated preflight checks into job initialization |
src/Test/L0/Worker/SnapshotOperationProviderL0.cs |
Updated test to verify new logging output |
src/Test/L0/Worker/JobExtensionL0.cs |
Added comprehensive test coverage for preflight scenarios |
TingluoHuang
approved these changes
Oct 16, 2025
…WellKnownDistributedTaskVariables.RunnerEnvironment, out var runnerEnvironment)'
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
TingluoHuang
force-pushed
the
lg/preflight-snapshot
branch
from
a2a6bfb to
ba675bd
Compare
alinetskyi
pushed a commit
to CoreumFoundation/runner
that referenced
this pull request
Jan 26, 2026
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.