Skip to content

Conversation

@ailox
Copy link
Contributor

@ailox ailox commented Dec 6, 2024

New licenses were added 7 months ago in jslicense/spdx-license-ids@6a6cd1d, but this logic is not used yet.

This PR fixes #854 as it updates the transient dependency, so that it is possible to use the Licenses.

@ailox ailox requested a review from a team as a code owner December 6, 2024 15:40
@ailox
Copy link
Contributor Author

ailox commented Dec 6, 2024

If helpful, I can also add a test that uses one of the newer licenses, so the resolution can be validated

@brrygrdn
Copy link
Contributor

👋🏻 Thanks for this contribution @ailox, this looks good to me. Would you mind running npm run package and checking in the dist changes on your branch? All the other checks are 👍🏻.

I don't think it's worth adding a unit specifically for the new licenses, but thanks for bringing it up!

@ailox
Copy link
Contributor Author

ailox commented Jan 9, 2025

I ran the command you supplied. I was struggling a little since the project had to be npm build first

@graysonguarino
Copy link

Have there been any updates on this PR? We are seeing the same issue and are curious when a fix will be merged.

@brrygrdn brrygrdn merged commit 51699b6 into actions:main Apr 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] action does fail with valid licenses like Unicode-3.0

3 participants