Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: actions/create-github-app-token
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.3.0
Choose a base ref
...
head repository: actions/create-github-app-token
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.4.0
Choose a head ref
  • 2 commits
  • 12 files changed
  • 2 contributors

Commits on Oct 6, 2023

  1. feat: Add a skip_token_revoke input for configuring token revocation (

    #54)
    
    Fixes #55
    
    Currently, `actions/create-github-app-token` always/unconditionally
    revokes the installation access token in a `post` step, at the
    completion of the current job. This prevents tokens from being used in
    other jobs.
    
    This PR makes this behavior configurable:
    - When the `skip-token-revoke` input is not specified (i.e. by default),
    the token is revoked in a `post` step (i.e. the current behavior).
    - When the `skip-token-revoke` input is set to a truthy value (e.g.
    `"true"`[^1]), the token is not revoked in a `post` step.
    
    This PR adds a test for the `skip-token-revoke: "true"` case.
    
    This is configurable in other app token actions, e.g.
    [tibdex/github-app-token](https://github.com/tibdex/github-app-token/blob/3eb77c7243b85c65e84acfa93fdbac02fb6bd532/README.md?plain=1#L46-L47)
    and
    [wow-actions/use-app-token](https://github.com/wow-actions/use-app-token/blob/cd772994fc762f99cf291f308797341327a49b0c/README.md?plain=1#L132).
    
    [^1]: Note that `"false"` is also truthy: `Boolean("false")` is `true`.
    If we think that’ll potentially confuse folks, I can require
    `skip-token-revoke` to be set explicitly to `"true"`.
    smockle authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    9ec88c4 View commit details
    Browse the repository at this point in the history
  2. 2 Configuration menu
    Copy the full SHA
    8210939 View commit details
    Browse the repository at this point in the history
Loading