Repository navigation
Commit f3a828e
ci: create signed dist commits in release workflow (#404)
The `main` ruleset requires verified signatures, but the "chore: update
dist files" commit on release-please PRs isn't signed.
`git-auto-commit-action` creates it with plain `git push`. [Unsigned
commits on the head branch can block squash merges
too](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/available-rules-for-rulesets#require-signed-commits),
so the dist commit itself needs a signature.
This replaces `git-auto-commit-action` with
[`dsanders11/github-app-commit-action`](https://github.com/dsanders11/github-app-commit-action),
pinned to the v2.1.0 commit SHA. It creates the commit through the REST
Git Data API with the releaser app token, and GitHub signs commits that
a GitHub App creates that way.
- A new `git add dist` step stages the rebuilt files. The action commits
only staged changes, so this replaces `file_pattern: dist/**`.
- `commit_author` is removed. GitHub signs API commits only when they
don't set a custom author, so the commit is now authored by the releaser
app instead of `github.actor`.
- `fail-on-no-changes: false` keeps the old behavior of skipping the
commit when dist didn't change.
The action uploads files as blobs, so the roughly 900 KB bundles aren't
a problem. The releaser app token is still needed: if the commit used
`GITHUB_TOKEN`, `test` wouldn't run on release PRs.
The first release run after merging will confirm the commit shows as
verified.
Co-authored-by: Copilot App <[email protected]>
Copilot-Session: c91009d9-b4f7-4eec-b30f-4b24ae578aa11 parent 655017f commit f3a828e
1 file changed
Lines changed: 7 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
55 | 58 | | |
56 | 59 | | |
57 | | - | |
58 | | - | |
59 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
60 | 63 | | |
61 | 64 | | |
62 | 65 | | |
| |||
0 commit comments