Skip to content

Provide better errors for unsupported event types#68

Merged
joshmgross merged 5 commits intomasterfrom
joshmgross/validate-event-type
Nov 13, 2019
Merged

Provide better errors for unsupported event types#68
joshmgross merged 5 commits intomasterfrom
joshmgross/validate-event-type

Conversation

@joshmgross
Copy link
Copy Markdown
Contributor

Currently, only push and pull_request events work with the cache service, other events will fail server authorization with an error like "No scopes with read permission were found on the request."

Failing early during verification makes it clear why reading and restoring the cache is failing.

Resolves #64

@joshmgross joshmgross requested a review from yacaovsnc November 7, 2019 19:20
@joshmgross joshmgross merged commit b7d83b4 into master Nov 13, 2019
@joshmgross joshmgross deleted the joshmgross/validate-event-type branch December 12, 2019 20:18
@joshmgross joshmgross mentioned this pull request May 17, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsupported event types should be blocked as verification errors

2 participants