-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Golang example tweak - add go-build
path - rebuild page TOC
#577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, noted the TOC was a little out of sync - so fixed it up with (warning, self plug!) my little Markdown TOC generate utility.
Hey, that's an awesome utility! Turn it into a GitHub Action so it can check TOCs before merging PRs! 😜
Just one comment/question about the path on different OS'es. Thanks for submitting this PR!
@@ -114,7 +118,9 @@ steps: | |||
```yaml | |||
- uses: actions/cache@v2 | |||
with: | |||
path: ~/go/pkg/mod | |||
path: | | |||
~/.cache/go-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with Golang, but while googling this I came across this cache example that shows different paths for different OS'es. That link suggests this only works on Linux, correct? Is there an env var or command that can be used to get the build cache path dynamically? Or list out the paths to use for different OS'es?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦
Oh @dhadka you're on the money 👍 - this is why we have +1's 😄 .
I'll update the PR now with a cross-os way of doing this 👍 . Sorry, I spend my life in Linux build agents typically.
Thanks 👍 - something I might have to consider doing. |
Thanks @dhadka - split out the examples into Linux/macOS/Windows versions in 9c0250e. I was thinking, the alternative is you could call |
go-build
pathgo-build
path - rebuild page TOC
Small bump @dhadka (seems I can't re-request a review). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY for making those changes!
Thanks @dhadka 👍 |
A few small things:
~/.cache/go-build
path (build cache) in addition to the module cache.Finally, noted the TOC was a little out of sync - so fixed it up with (warning, self plug!) my little Markdown TOC generate utility.