Switch cache action to use the cache node package #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmgross
approved these changes
May 15, 2020
package.json
Outdated
| "@actions/io": "^1.0.1", | ||
| "uuid": "^3.3.3" | ||
| "@actions/cache": "^0.1.0" |
There was a problem hiding this comment.
Let's make sure we publish a v1 of @actions/cache before we publish this v2 action. Would be odd if we had a major action version consume a preview package
|
Let's add a note in the README pointing to the package in the toolkit |
|
Well, will Zstd support be removed? |
aiqiaoy
force-pushed
the
aiyan/use-cache-package
branch
from
956852b to
249a220
Compare
|
@imbsky See actions/toolkit#469 for the zstd fixes. |
|
(I just checked the PR 🙂) |
aiqiaoy
force-pushed
the
aiyan/use-cache-package
branch
from
4e389df to
e8d9126
Compare
aiqiaoy
force-pushed
the
aiyan/use-cache-package
branch
from
e8d9126 to
bcc23b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest change is in
setCacheState. We are now only saving cache key not the entire artifact cache object since cacheKey what we get back fromsaveCache.