Skip to content

Fix zstd not being used after zstd version upgrade to 1.5.4 on hosted runners#1118

Merged
lvpx merged 5 commits intomainfrom
pdotl/zstd-hotfix
Feb 21, 2023
Merged

Fix zstd not being used after zstd version upgrade to 1.5.4 on hosted runners#1118
lvpx merged 5 commits intomainfrom
pdotl/zstd-hotfix

Conversation

@lvpx
Copy link
Copy Markdown
Contributor

@lvpx lvpx commented Feb 20, 2023

Description

This PR adds changes to fix zstd not being used after zstd version upgrade to 1.5.4 on hosted runners. Please see this PR in actions/toolkit for changes.

Motivation and Context

Fixes #1110
Fixes #1114
Potentially fixes #1116

How Has This Been Tested?

Tested with all hosted runners using workflows and ensured all test cases pass on CI.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lvpx lvpx requested a review from a team as a code owner February 20, 2023 19:52
@github-actions github-actions bot requested a review from pallavx February 20, 2023 19:52
@rohanKanojia rohanKanojia mentioned this pull request Feb 21, 2023
Closed
@kduret
Copy link
Copy Markdown

kduret commented Feb 21, 2023

I confirm this fixed my issue
good job @pdotl

@lvpx lvpx merged commit 69d9d44 into main Feb 21, 2023
@DerTim1
Copy link
Copy Markdown

DerTim1 commented Feb 21, 2023

@pdotl Can you please tag that version and also move tag v3 to this release?

@lvpx
Copy link
Copy Markdown
Contributor Author

lvpx commented Feb 21, 2023

@DerTim1 I have tagged the version and moved it to v3.

@chetbox
Copy link
Copy Markdown

chetbox commented Feb 21, 2023 •
edited
Loading

I re-ran a job that was failing, which seems to have picked up a newer of action/cache@v3, but I am still having the same problem.

Download action repository 'actions/cache@v3' (SHA:95b455a0fba5a5e1770cc10ded51e5fe99a6737b)

Error: Failed to restore cache entry. Exiting as fail-on-cache-miss is set

I tried again with actions/cache@69d9d449aced6a2ede0bc19182fadc3a0a42d2b0 and it worked.

@pdotl it looks to me like the v3 tag needs to be moved to 69d9d449aced6a2ede0bc19182fadc3a0a42d2b0?

@lvpx
Copy link
Copy Markdown
Contributor Author

lvpx commented Feb 21, 2023

@chetbox fixed! 👍

@chetbox
Copy link
Copy Markdown

chetbox commented Feb 21, 2023

Thanks @pdotl, looks good now. Much appreciated.

@atsju
Copy link
Copy Markdown

atsju commented Feb 21, 2023

I had this problem first time today after the fix :
Download action repository 'actions/cache@v3' (SHA:69d9d449aced6a2ede0bc19182fadc3a0a42d2b0)
Cache not found for input keys: Windows-mingw810_64
https://github.com/atsju/DFTFringe/actions/runs/4233014638/jobs/7353437839
And the cache existed.
Are caches supposed to be invalidated automatically when the action is updated ?

@vmarkovtsev
Copy link
Copy Markdown

vmarkovtsev commented Feb 21, 2023 •
edited
Loading

Our CI has started to fail after the new release. It looks like either some or all files are not restored from the cache now. Example. The same cache worked on a different runner: link.
We tried to drop all the caches. That didn't help.

@cdce8p
Copy link
Copy Markdown
Contributor

cdce8p commented Feb 21, 2023

Are caches supposed to be invalidated automatically when the action is updated ?

That is expected. You'll need to rebuild all caches with v3.2.6.
That's because now the action correctly looks for zstd caches if it is installed and only if not falls back to the glib defaults. Over the last few days the zstd version parsing was broken which caused only glib caches to be created.

@edmorley edmorley mentioned this pull request Feb 24, 2023
Closed
@kevinmatthes kevinmatthes mentioned this pull request Feb 26, 2023
Closed
dapirian referenced this pull request in trunk-io/plugins Mar 9, 2023
@renovate
Update all non-major dependencies (#191)
6076efe 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/cache](https://togithub.com/actions/cache) | action | minor |
`v3.2.4` -> `v3.3.0` |
| [github/codeql-action](https://togithub.com/github/codeql-action) |
action | patch | `v2.2.3` -> `v2.2.5` |
| [trunk-io/trunk-action](https://togithub.com/trunk-io/trunk-action) |
action | patch | `v1.0.6` -> `v1.0.7` |

---

### Release Notes

<details>
<summary>actions/cache</summary>

### [`v3.3.0`](https://togithub.com/actions/cache/releases/tag/v3.3.0)

[Compare
Source](https://togithub.com/actions/cache/compare/v3.2.6...v3.3.0)

#### What's Changed

- Bug: Permission is missing in cache delete example by
[@&#8203;kotokaze](https://togithub.com/kotokaze) in
[https://github.com/actions/cache/pull/1123](https://togithub.com/actions/cache/pull/1123)
- Add `lookup-only` option by
[@&#8203;cdce8p](https://togithub.com/cdce8p) in
[https://github.com/actions/cache/pull/1041](https://togithub.com/actions/cache/pull/1041)

#### New Contributors

- [@&#8203;kotokaze](https://togithub.com/kotokaze) made their first
contribution in
[https://github.com/actions/cache/pull/1123](https://togithub.com/actions/cache/pull/1123)

**Full Changelog**: actions/cache@v3...v3.3.0

### [`v3.2.6`](https://togithub.com/actions/cache/releases/tag/v3.2.6)

[Compare
Source](https://togithub.com/actions/cache/compare/v3.2.5...v3.2.6)

##### What's Changed

- Updated branch in Force deletion of caches by
[@&#8203;t-dedah](https://togithub.com/t-dedah) in
[https://github.com/actions/cache/pull/1108](https://togithub.com/actions/cache/pull/1108)
- Fix zstd not being used after zstd version upgrade to 1.5.4 on hosted
runners by [@&#8203;pdotl](https://togithub.com/pdotl) in
[https://github.com/actions/cache/pull/1118](https://togithub.com/actions/cache/pull/1118)

**Full Changelog**: actions/cache@v3...v3.2.6

### [`v3.2.5`](https://togithub.com/actions/cache/releases/tag/v3.2.5)

[Compare
Source](https://togithub.com/actions/cache/compare/v3.2.4...v3.2.5)

##### What's Changed

- Rewrite readmes by [@&#8203;jsoref](https://togithub.com/jsoref) in
[https://github.com/actions/cache/pull/1085](https://togithub.com/actions/cache/pull/1085)
- Fixed typos and formatting in docs by
[@&#8203;kotewar](https://togithub.com/kotewar) in
[https://github.com/actions/cache/pull/1076](https://togithub.com/actions/cache/pull/1076)
- Fixing paths for OSes by
[@&#8203;kotewar](https://togithub.com/kotewar) in
[https://github.com/actions/cache/pull/1101](https://togithub.com/actions/cache/pull/1101)
- Release patch version update by
[@&#8203;Phantsure](https://togithub.com/Phantsure) in
[https://github.com/actions/cache/pull/1105](https://togithub.com/actions/cache/pull/1105)

##### New Contributors

- [@&#8203;jsoref](https://togithub.com/jsoref) made their first
contribution in
[https://github.com/actions/cache/pull/1085](https://togithub.com/actions/cache/pull/1085)

**Full Changelog**: actions/cache@v3...v3.2.5

</details>

<details>
<summary>github/codeql-action</summary>

###
[`v2.2.5`](https://togithub.com/github/codeql-action/compare/v2.2.4...v2.2.5)

[Compare
Source](https://togithub.com/github/codeql-action/compare/v2.2.4...v2.2.5)

###
[`v2.2.4`](https://togithub.com/github/codeql-action/compare/v2.2.3...v2.2.4)

[Compare
Source](https://togithub.com/github/codeql-action/compare/v2.2.3...v2.2.4)

</details>

<details>
<summary>trunk-io/trunk-action</summary>

###
[`v1.0.7`](https://togithub.com/trunk-io/trunk-action/releases/tag/v1.0.7)

[Compare
Source](https://togithub.com/trunk-io/trunk-action/compare/v1.0.6...v1.0.7)

Introduce a caching-only mode, controlled via `check-mode:
populate_cache_only`.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/trunk-io/plugins).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTkuMiIsInVwZGF0ZWRJblZlciI6IjM0LjE1OS4yIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
JannikWo
JannikWo reviewed Jul 17, 2024
View reviewed changes
dist/restore-only/index.js
}
else {
return constants_1.CompressionMethod.Zstd;
return constants_1.CompressionMethod.ZstdWithoutLong;
Copy link
Copy Markdown

@JannikWo JannikWo Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for digging out this old PR, I got here following a bug.
But why are we not checking for the used zstd version here? Shouldn't be constants_1.CompressionMethod.Zstd still used when zstd is above v1.3.2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pallavx pallavx Awaiting requested review from pallavx

2 more reviewers

@JannikWo JannikWo JannikWo left review comments

@bishal-pdMSFT bishal-pdMSFT bishal-pdMSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pallavx pallavx

Labels

None yet

Projects

None yet

Milestone

No milestone

10 participants

@lvpx @kduret @DerTim1 @chetbox @atsju @vmarkovtsev @cdce8p @bishal-pdMSFT @JannikWo @pallavx