Closed
Optimize getSubjectFromPath to avoid concurrent stat calls on large globs#352
Conversation
Merged
Co-authored-by: bdehamer <[email protected]>
Co-authored-by: bdehamer <[email protected]>
Co-authored-by: bdehamer <[email protected]>
Co-authored-by: bdehamer <[email protected]>
Copilot
AI
changed the title
[WIP] Update to address feedback from ESM conversion PR review
Optimize getSubjectFromPath to avoid concurrent stat calls on large globs
Feb 17, 2026
Collaborator
|
cherry-picked into #347 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #347 regarding performance issues when globs expand to large file lists.
Changes
Promise.all(paths.map(stat))with sequential iteration that terminates immediately when MAX_SUBJECT_COUNT is reachedBefore:
After:
Prevents issuing thousands of concurrent stat calls that could hit OS file descriptor limits or cause significant slowdown.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.