Honor repo flag on sync #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashtagchris
force-pushed
the
issue2
branch
from
0f55fbc to
d8d5f87
Compare
hashtagchris
commented
Sep 18, 2020
| nwo, err = validateNwo("bogus/bogus/bogus") | ||
| require.Error(t, err) | ||
|
|
||
| // A separate destination is only permitted for "repo names", not NWOs. |
Contributor
Author
There was a problem hiding this comment.
// A separate destination is only permitted for "repo names", not NWOs.
I almost added types for repoName and nwo to make the distinction clearer, but it looked like too much of a pain to convert string slices to another type.
anthonysterling
approved these changes
Sep 21, 2020
Contributor
anthonysterling
left a comment
anthonysterling
left a comment
There was a problem hiding this comment.
Thanks for this Chris, features++ and 🧹++ too. 🙇♂️
hashtagchris
force-pushed
the
issue2
branch
from
d8d5f87 to
1b9b483
Compare
hashtagchris
force-pushed
the
issue2
branch
from
1b9b483 to
fec74ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync. Ignore other actions in the cache directory.actions-sync versionso it doesn't require acache-dirflag.As part of these changes you can now optionally supply a repo flag to
pushas well, in case you don't want to push the whole cache.syncandpushuse the directories under the cache dir as a repo list if a repo flag wasn't supplied. There are a lot of code changes as a consequence of removingcache-diras a global flag, and utility functions being moved toreponames.go.Closes #2