Skip to content

Fix --cache-dir not actually being marked as a required flag. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anthonysterling merged 1 commit into from
Aug 10, 2020
Merged

Fix --cache-dir not actually being marked as a required flag. #7

anthonysterling merged 1 commit into from
Aug 10, 2020

Conversation

@chrisgavin
Copy link
Contributor

@chrisgavin chrisgavin commented Aug 6, 2020

cache-dir is a persistent flag so the method MarkPersistentFlagRequired is required to mark it as required.

It is currently possible to invoke the tool without passing --cache-dir at all which results in the confusing error message stat : no such file or directory.

anthonysterling
anthonysterling approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@anthonysterling anthonysterling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthonysterling anthonysterling merged commit 8cdfdec into actions:main Aug 10, 2020
@chrisgavin chrisgavin deleted the fix-cache-dir-not-required branch August 10, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@anthonysterling anthonysterling anthonysterling approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chrisgavin @anthonysterling