-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Not possible to deploy gha-runner-scale-set-controller helm chart via Fluxcd #3728
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't workinggha-runner-scale-setRelated to the gha-runner-scale-set modeRelated to the gha-runner-scale-set modeneeds triageRequires review from the maintainersRequires review from the maintainers
Description
Checks
- I've already read https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/troubleshooting-actions-runner-controller-errors and I'm sure my issue is not covered in the troubleshooting guide.
- I am using charts that are officially provided
Controller Version
0.9.3
Deployment Method
Helm
Checks
- This isn't a question or user support case (For Q&A and community support, go to Discussions).
- I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes
To Reproduce
1. Deploy the gha-runner-scale-set-controller helm chart via Fluxcd. Flux yaml files are added in additional context.
2. Deployment fails with error:
NAME REVISION SUSPENDED READY MESSAGE
arc 0.9.3+4fda46fd8c4e False False Helm install failed for release arc systems/arc with chart [email protected]+4fda46fd8c4e: 1 error occurred: * Deployment.apps "arc-gha-rs-controller" is invalid: spec.template.labels: Invalid value: "0.9.3+4fda46fd8c4e": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')Describe the bug
The chart revision is used in the arc-gha-rs-controller Deployment which contains a + sign which is not allowed.
Describe the expected behavior
Succesfull deployment of arc-gha-rs-controller
Additional Context
apiVersion: source.toolkit.fluxcd.io/v1beta2
kind: OCIRepository
metadata:
name: arc
namespace: arc-systems
spec:
interval: 10m
url: oci://ghcr.io/actions/actions-runner-controller-charts/gha-runner-scale-set-controller
ref:
tag: 0.9.3
---
apiVersion: helm.toolkit.fluxcd.io/v2
kind: HelmRelease
metadata:
name: arc
namespace: arc-systems
spec:
interval: 5m
install:
remediation:
retries: 10
releaseName: arc
targetNamespace: arc-systems
chartRef:
kind: OCIRepository
name: arcController Logs
None, not yet runningRunner Pod Logs
None, not yet runningReactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggha-runner-scale-setRelated to the gha-runner-scale-set modeRelated to the gha-runner-scale-set modeneeds triageRequires review from the maintainersRequires review from the maintainers