Skip to content

Conversation

@fanquake
Copy link
Contributor

Fully remove macholib (also drops altgraph subdep).

@fanquake fanquake force-pushed the fully_drop_macholib branch from f67685a to cc3c8b6 Compare November 13, 2023 13:37
@achow101
Copy link
Owner

ACK cc3c8b6

@achow101 achow101 merged commit 6215571 into achow101:master Nov 13, 2023
@fanquake fanquake deleted the fully_drop_macholib branch November 13, 2023 16:11
fanquake added a commit to fanquake/bitcoin that referenced this pull request Nov 13, 2023
Which includes achow101/signapple#13.
We can drop macholib (and altgraph) as deps.
@Sjors
Copy link
Contributor

Sjors commented Nov 14, 2023

Is there some previous change here or in Bitcoin Core that makes dropping macholib possible?

@fanquake
Copy link
Contributor Author

It was replaced with elfsteem. See commits from: 18a036b.

fanquake added a commit to bitcoin-core/gui that referenced this pull request Nov 15, 2023
…graph)

f718a74 guix: remove python-macholib (fanquake)
d3cbff1 guix: update signapple (fanquake)

Pull request description:

  Update to the latest signapple, which includes achow101/signapple#13.
  Drop python-macholib and python-altgraph.

ACKs for top commit:
  Sjors:
    ACK f718a74

Tree-SHA512: 199b2108f2f063b6b0fb5354ac79a30b46e848c923ebe7d02f7d7d3f08749817a1f6b4c14d21658fd2f2d68f8be1698e1999edf7e2366b1cae3bf2709a665e30
janus pushed a commit to BitgesellOfficial/bitgesell that referenced this pull request Apr 1, 2024
Which includes achow101/signapple#13.
We can drop macholib (and altgraph) as deps.
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Feb 17, 2025
f718a74 guix: remove python-macholib (fanquake)
d3cbff1 guix: update signapple (fanquake)

Pull request description:

  Update to the latest signapple, which includes achow101/signapple#13.
  Drop python-macholib and python-altgraph.

ACKs for top commit:
  Sjors:
    ACK f718a74

Tree-SHA512: 199b2108f2f063b6b0fb5354ac79a30b46e848c923ebe7d02f7d7d3f08749817a1f6b4c14d21658fd2f2d68f8be1698e1999edf7e2366b1cae3bf2709a665e30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants