Hey, thanks for the pr, can you give a bit of context for these changes please?

Codecov Report

Merging #493 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #493   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          57       57           
  Lines        1277     1277           
  Branches      179      179           
=======================================
  Hits         1223     1223           
  Misses         51       51           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80f587...a9162a6. Read the comment docs.

Hi @pradel,
Sorry for late response.
We just released GraphQL-Modules which provides you to implement your GraphQL applications or libraries in modular approach together with features like Depenedency Injection, Resolvers Composition etc.
I am one of the contributors of that project.
You can read more in this article and its website;
https://medium.com/the-guild/graphql-modules-feature-based-graphql-modules-at-scale-2d7b2b0da6da
https://graphql-modules.com

We would love to see AccountsJS has built-in GraphQL-Modules support, and uses the benefits of our library. @dotansimha is one of the main contributors of GraphQL-Modules, and AFAIK he also contributed to graphql-api package of yours.

We also want to write a blog post about a GraphQL boilerplate with Authentication using GraphQL-Modules and AccountsJS together with GraphQL Code Generator's TypeScript benefits that will be so much easy to start a GraphQL project with Authentication for beginners.

To sum up, the benefits are;

• You don't need to think about the support of GraphQL libraries and the other stuff. This is what GraphQL-Modules will take care of for you.
• GraphQL-Modules has built-in support for Apollo Server and graphql-yoga even if they're not using GraphQL-Modules.
• GraphQL-Modules also supports GraphQL Code Generator out of the box which generates client-side and server-side typings including resolvers signatures, and strictly-typed React-Apollo and Apollo Angular components and services. That will be also included in your graphql-api package if you start to use GraphQL-Modules with this PR.
• https://medium.com/the-guild/graphql-code-generator-v0-11-15bb9b02899e

I think it's great :)
It's exposing a clean GraphQLModule which you can use with graphql-modules, but the module is also independent, so you can get typeDey/resolvers/GraphQLSchema as standalone and use it without graphql-modules.

@davidyaha what do you think? 😄

I think this is a great idea, will review soon, thanks for the contribution!

I like the idea too!
Will take a deeper look when I have some time :)

Code looks good and e2e tests are passing!
I just have one question since I am not familiar with graphql-modules.
How can a user extends the User type to add additional fields?
For example right now you can do it like this:

const typeDefs = `
  extends type User {
	firstname: String!
  }
`;

Then this field will be injected by the account module user resolver directly

Same when we are creating a new user, how to extends the createUser input with new variables?

Everything is same if you're not using GraphQL-Modules, I mean the exported schema is exactly same like before; so you can still use extend for extending inputs and other types. But for GraphQL-Modules users, there is no need to add extend operator, because GraphQL-Modules handles that for you :) The only thing you need to do is to import AccountsModule to your application module which contains extra fields etc.

import { AccountsModule } from '@accounts/graphql-api';
import { GraphQLModule } from '@graphql-modules/core';

export const AppModule = new GraphQLModule({
  typeDefs: gql`
    type User {
	firstname: String!
  }
    input CreateUserInput {
         firstName: String!
    }
  `,
  resolvers: {...},
  imports: [
   AccountsModule.forRoot({...})
  ]
});

const { typeDefs } = AppModule;
// Now typeDefs has User and CreateUserInput types with firstname and other fields from AccountsModule

Amazing thanks for the explanation @ardatan!
We will have to reflect that in the documentation :)

@pradel Thank you for your good thoughts :) It is really great to see these two projects together.

@dotansimha Graphql Modules sounds great! Congrats on open sourcing it!!
Hadn't tried it myself yet but it looks like a very good approach and could be very much inline with accounts-js IMO.
Unfortunately I don't have the time to review but it seems like @pradel and @TimMikeladze are on it.
Thanks for the contribution @ardatan!

@pradel @TimMikeladze @davidyaha Any chance we can get it merged and released soon? 😄
Thanks!

I can merge and cut a release within the next 24 hours.

Thanks for the PR 👍

Merged and published. 0.5.0-alpha.1