Make the cs_sendProcessing a LOCK instead of a TRY_LOCK

TheBlueMatt · TheBlueMatt · commit 376b3c2c6e32 · 2017-01-13T10:34:38.000-08:00
Technically cs_sendProcessing is entirely useless now because it
is only ever taken on the one MessageHandler thread, but because
there may be multiple of those in the future, it is left in place
diff --git a/src/net.cpp b/src/net.cpp
@@ -1871,9 +1871,8 @@ void CConnman::ThreadMessageHandler()
 
             // Send messages
             {
-                TRY_LOCK(pnode->cs_sendProcessing, lockSend);
-                if (lockSend)
-                    GetNodeSignals().SendMessages(pnode, *this, flagInterruptMsgProc);
+                LOCK(pnode->cs_sendProcessing);
+                GetNodeSignals().SendMessages(pnode, *this, flagInterruptMsgProc);
             }
             if (flagInterruptMsgProc)
                 return;

Original file line number	Diff line number	Diff line change
`@@ -1871,9 +1871,8 @@ void CConnman::ThreadMessageHandler()`
`1871`	`1871`
`1872`	`1872`	`// Send messages`
`1873`	`1873`	`{`
`1874`		`- TRY_LOCK(pnode->cs_sendProcessing, lockSend);`
`1875`		`- if (lockSend)`
`1876`		`- GetNodeSignals().SendMessages(pnode, *this, flagInterruptMsgProc);`
	`1874`	`+ LOCK(pnode->cs_sendProcessing);`
	`1875`	`+ GetNodeSignals().SendMessages(pnode, *this, flagInterruptMsgProc);`
`1877`	`1876`	`}`
`1878`	`1877`	`if (flagInterruptMsgProc)`
`1879`	`1878`	`return;`