Optimize cache key retrieval in configuration client #24495
Merged
+30
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes cache key retrieval in the MvcCachedApplicationConfigurationClient by caching the cache key itself in the HttpContext.Items collection. This prevents redundant calls to CreateCacheKeyAsync() within the same HTTP request context.
Key Changes:
- Added cache key caching in
HttpContext.Itemsto avoid repeated computation of the same cache key - Applied the optimization to both
GetAsync()andGet()methods
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...NetCore.Mvc.Client/Volo/Abp/AspNetCore/Mvc/Client/MvcCachedApplicationConfigurationClient.cs
Outdated
Show resolved
Hide resolved
...NetCore.Mvc.Client/Volo/Abp/AspNetCore/Mvc/Client/MvcCachedApplicationConfigurationClient.cs
Show resolved
Hide resolved
EngincanV
approved these changes
Dec 29, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel-10.0 #24495 +/- ##
============================================
- Coverage 51.02% 50.98% -0.05%
============================================
Files 3294 3296 +2
Lines 107441 107518 +77
Branches 8255 8255
============================================
- Hits 54823 54817 -6
- Misses 50923 51007 +84
+ Partials 1695 1694 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.