Skip auditing for navigations with DisableAuditing attribute #24446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for skipping auditing of navigation properties when they are decorated with the [DisableAuditing] attribute. This resolves issue #24441 by allowing developers to selectively disable audit logging for specific navigation properties while maintaining auditing for the parent entity.
Key Changes
- Added attribute check in
EntityHistoryHelper.GetPropertyChanges()to skip navigation properties marked with[DisableAuditing] - Created test entity with a navigation property marked with
[DisableAuditing]to verify the functionality - Added unit test to ensure navigation property changes are not audited when the attribute is present
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| EntityHistoryHelper.cs | Added check for DisableAuditingAttribute on navigation properties before recording property changes |
| AbpAuditingTestDbContext.cs | Added DbSet for new test entity with DisableAuditing on navigation property |
| AppEntityWithNavigationsAndDisableAuditing.cs | Created test entities to verify DisableAuditing behavior on navigation properties |
| Auditing_Tests.cs | Added test case to verify navigation changes are skipped when DisableAuditing is applied |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
....Auditing.Tests/Volo/Abp/Auditing/App/Entities/AppEntityWithNavigationsAndDisableAuditing.cs
Show resolved
Hide resolved
EngincanV
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #24441