Improve focus handling for form field visibility #24187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored focus logic to ensure the field is only focused when visible. Added IntersectionObserver to handle cases where the element is not immediately visible, improving accessibility and user experience.
Contributor
sumeyyeKurtulus
left a comment
sumeyyeKurtulus
left a comment
There was a problem hiding this comment.
Hello @fahrigedik thank you for checking this problem in the forms. However, we can call the animation frame request instead which is more straightforward and clean
requestAnimationFrame(() => {
this.fieldRef.nativeElement.focus();
});Replaces the IntersectionObserver-based focus logic with a simpler requestAnimationFrame approach for focusing the first field. This reduces complexity and potential timing issues when focusing the field after view initialization.
sumeyyeKurtulus
approved these changes
Nov 17, 2025
yagmurcelk
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored focus logic to ensure the field is only focused when visible. Added IntersectionObserver to handle cases where the element is not immediately visible, improving accessibility and user experience.
Description
Resolves https://github.com/volosoft/vs-internal/issues/7593 (write the related issue number if available)
Checklist
How to test it?
you have to change branch rel-9.3 on volo
you have to change branch issue-7593 on abp
you have to change branch rel-4.3 on lepton
and you can run commercial test app on vs-internal