Change TelemetryActivityEventBuilder to transient dependency #24093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve #23755 NET doesn't allow consuming a scoped service from a singleton service.
hikalkan
approved these changes
Nov 6, 2025
Member
|
This service doesn't need to be a singleton in any way since it doesn't store a state. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #23343
Resolve #23755
The ASP.NET Core default dependency injection system doesn't allow consuming a scoped service from a singleton service.
This error only happened if we didn't call the
UseAutofac(Use Autofac to replace default).