Use safe redirect after registration in Account Module #24059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces direct Redirect with RedirectSafelyAsync after user registration to enhance security when handling return URLs.
salihozkara
approved these changes
Oct 30, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances redirect security in the registration process by replacing a direct URL redirect with the safer RedirectSafelyAsync method. This addresses the open security TODO comment about ensuring redirect URL safety.
- Replaces unsafe
Redirect()call withRedirectSafelyAsync()to validate redirect URLs - Removes the TODO comment about redirect URL safety verification
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
modules/account/src/Volo.Abp.Account.Web/Pages/Account/Register.cshtml.cs
Outdated
Show resolved
Hide resolved
maliming
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces direct Redirect with RedirectSafelyAsync after user registration to enhance security when handling return URLs.
Checklist