Refactor SEO description script and update workflow #24000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved modularity and readability of add_seo_descriptions.py by refactoring functions, enhancing block handling, and adding statistics saving. Updated auto-add-seo.yml to correctly detect changed markdown files using PR head and base SHAs for more accurate file selection.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the SEO description script for improved maintainability and updates the workflow to use PR head commits instead of merge commits.
- Refactored Python script with better code organization and function separation
- Updated workflow to reference PR head SHA instead of merge commit SHA
- Added explicit line ending preservation when reading/writing files
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/auto-add-seo.yml | Updated to use PR head SHA for more reliable file change detection |
| .github/scripts/add_seo_descriptions.py | Refactored with extracted functions, constants, and improved code organization |
Comments suppressed due to low confidence (1)
.github/scripts/add_seo_descriptions.py:1
- The emoji character appears corrupted in the output. Should use '🚫' (prohibited sign emoji).
import os
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Added note about uninstalling the old ABP CLI before installing the new one.
maliming
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.