Skip to content

Add password reuse prevention localization to all Identity module languages #23909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maliming merged 3 commits into from
Oct 8, 2025
Merged

Add password reuse prevention localization to all Identity module languages #23909

maliming merged 3 commits into from
Oct 8, 2025

Conversation

Copy link
Contributor

Copilot AI commented Oct 8, 2025 •
edited
Loading

  • Understand the repository structure and locate all localization files
  • Verify the English localization file already has the required entries
  • Add the four localization keys to all 26 non-English JSON files
  • Fix translations that were still in English (12 languages):
    • el.json (Greek) - Now properly translated
    • fa.json (Persian) - Now properly translated
    • fi.json (Finnish) - Now properly translated
    • hi.json (Hindi) - Now properly translated
    • hr.json (Croatian) - Now properly translated
    • hu.json (Hungarian) - Now properly translated
    • is.json (Icelandic) - Now properly translated
    • ro-RO.json (Romanian) - Now properly translated
    • sk.json (Slovak) - Now properly translated
    • sl.json (Slovenian) - Now properly translated
    • sv.json (Swedish) - Now properly translated
    • vi.json (Vietnamese) - Now properly translated
  • Verify all JSON files are valid

Summary

Successfully added four password reuse prevention localization keys to all 27 JSON files in the Identity module. All translations are now properly localized for each language.

Languages with Proper Translations:

✅ All 27 languages now have culturally appropriate translations
✅ No files contain English text (except en.json and en-GB.json)
✅ All JSON files validated successfully

Original prompt

Please add four DisplayName:Abp.Identity.Password.EnablePreventPasswordReuse, DisplayName:Abp.Identity.Password.PreventPasswordReuseCount, Description:Abp.Identity.Password.nablePreventPasswordReuse, Description:Abp.Identity.Password.PreventPasswordReuseCount localization texts to all *.json files that are under: modules/identity/src/Volo.Abp.Identity.Domain.Shared/Volo/Abp/Identity/Localization/ folder and translate it into the corresponding language. eg: tr, zh-Hans...

You can refer to modules/identity/src/Volo.Abp.Identity.Domain.Shared/Volo/Abp/Identity/Localization/en.json file.

English version localization texts are:

"DisplayName:Abp.Identity.Password.EnablePreventPasswordReuse": "Enable prevent password reuse",
"DisplayName:Abp.Identity.Password.PreventPasswordReuseCount": "Prevent password reuse count",

"Description:Abp.Identity.Password.EnablePreventPasswordReuse": "Whether to prevent users from reusing their previous passwords.",
"Description:Abp.Identity.Password.PreventPasswordReuseCount": "The number of previous passwords that cannot be reused."

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLAassistant commented Oct 8, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI changed the title [WIP] Add localization for password reuse prevention settings Add password reuse prevention localization to all Identity module languages Oct 8, 2025
Copilot AI requested a review from maliming October 8, 2025 05:51
@maliming
Copy link
Member

maliming commented Oct 8, 2025

@copilot

Some files have not been translated from English to the corresponding language.

eg:
modules/identity/src/Volo.Abp.Identity.Domain.Shared/Volo/Abp/Identity/Localization/el.json
modules/identity/src/Volo.Abp.Identity.Domain.Shared/Volo/Abp/Identity/Localization/fa.json
modules/identity/src/Volo.Abp.Identity.Domain.Shared/Volo/Abp/Identity/Localization/fi.json
·...·

Please check all the JSON files to complete the translation.

Thanks

Copy link
Contributor Author

Copilot AI commented Oct 8, 2025

@copilot

Some files have not been translated from English to the corresponding language.
...

Fixed in commit 3c87dc1. All 12 files (el, fa, fi, hi, hr, hu, is, ro-RO, sk, sl, sv, vi) now have proper localized translations instead of English text. Verified all 27 JSON files are valid and properly translated.

@maliming maliming marked this pull request as ready for review October 8, 2025 06:03
Copilot AI requested a review from maliming October 8, 2025 06:03
@maliming maliming merged commit 910b8e9 into PasswordHistory Oct 8, 2025
1 check was pending
@maliming maliming deleted the copilot/add-password-reuse-prevention-localization branch October 8, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maliming maliming Awaiting requested review from maliming

Assignees

@maliming maliming

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CLAassistant @maliming