Skip to content

Add indeterminate state to 'Select All' checkbox #23846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yagmurcelk merged 3 commits into from
Oct 7, 2025
Merged

Add indeterminate state to 'Select All' checkbox #23846

yagmurcelk merged 3 commits into from
Oct 7, 2025

Conversation

@maliming
Copy link
Member

@maliming maliming commented Oct 2, 2025

image

@maliming maliming requested a review from yagmurcelk October 2, 2025 05:45
@maliming maliming added this to the 10.0-final milestone Oct 3, 2025
yagmurcelk
yagmurcelk requested changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@yagmurcelk yagmurcelk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we search for permissions and remove them, the "Grant All Permissions" icon does not display correctly. it appears as if not all permissions are granted.

screen-capture.1.webm

@maliming
Copy link
Member Author

maliming commented Oct 7, 2025

When we search for permissions and remove them, the "Grant All Permissions" icon does not display correctly. it appears as if not all permissions are granted.

screen-capture.1.webm

Fixed by 6608305

@yagmurcelk yagmurcelk self-requested a review October 7, 2025 10:08
yagmurcelk
yagmurcelk requested changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@yagmurcelk yagmurcelk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we first open the modal and select the grant all permissions option for all permissions, the icon is not displayed correctly. The second click fixes it.

screen-capture.2.webm

@maliming
Copy link
Member Author

maliming commented Oct 7, 2025

When we first open the modal and select the grant all permissions option for all permissions, the icon is not displayed correctly. The second click fixes it.

screen-capture.2.webm

FIxed by aceb45d

@yagmurcelk yagmurcelk self-requested a review October 7, 2025 13:28
@yagmurcelk yagmurcelk merged commit 7d9a97c into rel-10.0 Oct 7, 2025
3 checks passed
@yagmurcelk yagmurcelk deleted the Permission-Indeterminate branch October 7, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yagmurcelk yagmurcelk yagmurcelk approved these changes

Assignees

No one assigned

Labels

abp-module-permission-management

Projects

None yet

Milestone

10.0-final

Development

Successfully merging this pull request may close these issues.

3 participants

@maliming @yagmurcelk