Add Specific Error Codes for Authentication Failures #20716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kenController.Password
alihdev
force-pushed
the
login_failed_error_code
branch
from
bdc2424 to
6d81e93
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
Author
|
@maliming, could you take a look at this? |
Member
|
hi @alihdev Thanks. I will check it. |
maliming
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently, all authentication failures return the same error code (InvalidGrant), making it difficult to distinguish between different failure reasons on the front end.
Introducing specific error codes (account_locked, account_inactive, and invalid_grant) will allow us to check whether an account is locked out, inactive, or if the credentials are invalid, enabling the front end to handle these scenarios more effectively.