Reopening for review after this message from @tfranzel #542 (comment)

Hi,
I watched this a bit from the sidelines and I have to admit I'm a bit puzzled. Maybe I have been too imprecise in my statements.

nobody is forcing you to use the CDN. if you are so inclined, you are free to change those settings and host your swagger-ui build yourself. that is exactly the reason why the setting is there.

You then partially did what I recommended; ingesting the distribution builds into your static folder. So far so good. However, instead of simply setting 'REDOC_DIST': '//cdn.jsdelivr.net/npm/redoc@next' to 'REDOC_DIST': 'YOUR_STATIC_ROOT/api_doc', you went ahead removed spectacular altogether and hard-coded the schema. You could call that throwing out the baby with the bath water.

The whole point of spectacular is not having stale, outdated hard-coded API specifications. This kind of defeats the purpose of the whole thing but I digress. But on a lighter note, we just added your request: https://github.com/tfranzel/drf-spectacular#self-contained-ui-installation

This installs https://github.com/tfranzel/drf-spectacular-sidecar, which is an optional package containing all those assets. The package sources from jsdelivr and releases a PyPi package containing those static files. Basically what you did in this PR. Just some food for thought. Have a good day!

Uh oh!

drf-spectacular is fetching JS from CDN #454

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions