Repository navigation
Ignore macOS .DS_Store files by default #1874 - #2286
Open
codewithfourtix wants to merge 1 commit into
Open
codewithfourtix wants to merge 1 commit into
codewithfourtix wants to merge 1 commit into
Conversation
Add .DS_Store to the default ignored patterns, next to the __MACOSX folder, so these Finder metadata files are flagged before any mapping or PurlDB matching runs. Signed-off-by: Ali Zulfiqar <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1874
.DS_Storeis now inDEFAULT_IGNORED_PATTERNS, next to__MACOSX, soflag_ignored_resourcesmarks these filesignored-patternbefore any mapping or PurlDB matching step runs. Unlike #2016, which excluded them from a single matching query, this keeps them out of every step and every pipeline.Not covered: removing
.DS_Storefiles from the PurlDB index, the second half of the issue.