Merged
Conversation
tdruez
requested changes
May 22, 2024
Contributor
tdruez
left a comment
tdruez
left a comment
There was a problem hiding this comment.
It's a good start. We are missing unit tests though.
Reference: #1237 Reference: #1066 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
resolve-dependencies-from-lockfile
branch
from
adc55dc to
5cf11ac
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
tdruez
requested changes
Jun 13, 2024
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Resolves dependency for cases where multiple requirements are resolved by one package and all the version requirements are joined for that package. Reference: #1237 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
tdruez
reviewed
Jun 17, 2024
AyanSinhaMahapatra
force-pushed
the
resolve-dependencies-from-lockfile
branch
from
ddead3b to
60050fe
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
resolve-dependencies-from-lockfile
branch
from
60050fe to
65e652d
Compare
Reference: https://github.com/nexB/scancode-toolkit/releases/tag/v32.2.0 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Handle various lockfile cases where: * Same package/dependencies are present in different lockfiles * Independent lockfiles without a manifest and root package * Ecosystems which have only a single version of package in their environment * Dependency graphs where a resolved package can have many parent packages. Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
resolve-dependencies-from-lockfile
branch
from
10eae0c to
795a740
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
resolve-dependencies-from-lockfile
branch
from
795a740 to
fae73bf
Compare
Member
Author
|
@tdruez ready for review again! |
tdruez
requested changes
Jun 27, 2024
Contributor
tdruez
left a comment
tdruez
left a comment
There was a problem hiding this comment.
@AyanSinhaMahapatra That looks good, see my minor suggestions.
Also, do you think we have a good enough test coverage for the new resolution features?
AyanSinhaMahapatra
force-pushed
the
resolve-dependencies-from-lockfile
branch
from
abaaf95 to
9e279b5
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
resolve-dependencies-from-lockfile
branch
from
9e279b5 to
44711ea
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
tdruez
requested changes
Jul 1, 2024
Contributor
tdruez
left a comment
tdruez
left a comment
There was a problem hiding this comment.
@AyanSinhaMahapatra Looks good, almost ready for merge.
See a few minor change requests.
We are missing a changelog entry that summarize all the changes of this PR.
It's quite an important one.
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Member
Author
|
@tdruez thanks, I've addressed your comments and added the CHANGELOG entries, ready for review again. |
This was referenced Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures we provide general support for dependency resolution in ScanCode.io:
This is the actual implementation of: