Build filetree with missing directories to support --only-findings scans#624
Build filetree with missing directories to support --only-findings scans#624
Conversation
Signed-off-by: Omkar Phansopkar <[email protected]>
There was a problem hiding this comment.
@OmkarPh thanks++
Looks good and needs a couple more edge-cases handling, based on problems detected in larger scans.
Consider the following scans:
postgresml-2.8.1.json
postgresml-2.8.1-only-findings.json
See comments below:
- In the only-findings scan, the file-tree is not behaving correctly for nested directories (as the corresponding parent directories are missing?) should we populate missing parent directories ourself while importing the scan? Example resource:
"postgresml-2.8.1/pgml-cms/docs/resources/benchmarks/mindsdb-vs-postgresml.md"this is not present in the file tree on the left. And the expand directory icon also hangs for some reason? - In your allsamples-onlyfindings-noresources.json.txt example, when we import this, nothing happens are there are no resources. I would like to see something to indicate that there was no resources in the scan and so we can't show anything.
Signed-off-by: Omkar Phansopkar <[email protected]>
Sure, I'll add a warning/error snackbar with this message |
If there's no data at all (here I mainly mean no file data, as other codebase level attributes are atleast option-dependent) there's no use showing empty views, so it's fine if we abort importing and show the message there. |
Signed-off-by: Omkar Phansopkar <[email protected]>
|
Thanks for the feedback @AyanSinhaMahapatra |
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
@OmkarPh LGTM! Thanks++
The issues mentioned above are fixed now and this is ready to merge.
Please release too 🚀

Fixes #404 #393
--only-findingsoption by imputing required intermediate directoriesReference scans -
allsamples-onlyfindings.json.txt
allsamples-onlyfindings-noresources.json.txt